Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused code in server/mock #4500

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Remove unused code in server/mock #4500

merged 1 commit into from
Jun 6, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Jun 6, 2019 •
edited
Loading

Remove unnecessary auth dependency from the server package.

Work carried out in the context of #4488

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio requested review from sabau and fedekunze June 6, 2019 14:39
@alessio alessio changed the title Remove unnecessary auth dependency from the server package Remove unused code in server/mock Jun 6, 2019
sabau
sabau approved these changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@sabau sabau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

alexanderbez
alexanderbez approved these changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit 5b78a7b into master Jun 6, 2019
@alexanderbez alexanderbez deleted the alessio/decouple-server-x-auth branch June 6, 2019 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackzampolin jackzampolin jackzampolin approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@sabau sabau sabau approved these changes

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@fedekunze fedekunze Awaiting requested review from fedekunze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alessio @sabau @alexanderbez @jackzampolin